github-vet / github-vet/rangeloop-pointer-findings

agoda-com/samsahai: api/v1beta1/zz_generated.deepcopy.go; 21 LoC

Open
#17,919 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [agoda-com/samsahai](https://www.github.com/agoda-com/samsahai) at [api/v1beta1/zz_generated.deepcopy.go](https://github.com/agoda-com/samsahai/blob/5e3ed70734c5cce2b7fef42540b9d2032935a91a/api/v1beta1/zz_generated.deepcopy.go#L775-L795)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to val is reassigned at line 780

[Click here to see the code in its original context.](https://github.com/agoda-com/samsahai/blob/5e3ed70734c5cce2b7fef42540b9d2032935a91a/api/v1beta1/zz_generated.deepcopy.go#L775-L795)

Click here to show the 21 line(s) of Go which triggered the analyzer.

```go
for key, val := range *in {
var outVal map[string][]string
if val == nil {
(*out)[key] = nil
} else {
in, out := &val, &outVal
*out = make(ChartValuesURLs, len(*in))
for key, val := range *in {
var outVal []string
if val == nil {
(*out)[key] = nil
} else {
in, out := &val, &outVal
*out = make([]string, len(*in))
copy(*out, *in)
}
(*out)[key] = outVal
}
}
(*out)[key] = outVal
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 5e3ed70734c5cce2b7fef42540b9d2032935a91a

Contributor guide

No contributing guide indexed for this repository

Research direction

Read api/v1beta1/zz_generated.deepcopy.go around lines 775-795 and inspect the reported range-variable reference reassignment in context. Decide whether the analyzer finding is a bug, mitigated, or desirable behavior, then leave the corresponding reaction; completion is the selected classification.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
api
Issue type
Bug
Difficulty
2/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.