github-vet / github-vet/rangeloop-pointer-findings

ilaykav/nuclioTestService: pkg/processor/trigger/rabbitmq/trigger.go; 15 LoC

Open
#17,916 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [ilaykav/nuclioTestService](https://www.github.com/ilaykav/nuclioTestService) at [pkg/processor/trigger/rabbitmq/trigger.go](https://github.com/ilaykav/nuclioTestService/blob/c320e4c00d66a1ef42361f2ee5b61f6998fceb86/pkg/processor/trigger/rabbitmq/trigger.go#L172-L186)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to message is reassigned at line 175

[Click here to see the code in its original context.](https://github.com/ilaykav/nuclioTestService/blob/c320e4c00d66a1ef42361f2ee5b61f6998fceb86/pkg/processor/trigger/rabbitmq/trigger.go#L172-L186)

Click here to show the 15 line(s) of Go which triggered the analyzer.

```go
for message := range rmq.brokerInputMessagesChannel {

// bind to delivery
rmq.event.message = &message

// submit to worker
_, submitError, _ := rmq.AllocateWorkerAndSubmitEvent(&rmq.event, nil, 10*time.Second)

// ack the message if we didn't fail to submit
if submitError == nil {
message.Ack(false)
} else {
errors.Wrap(submitError, "Failed to submit to worker")
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: c320e4c00d66a1ef42361f2ee5b61f6998fceb86

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with pkg/processor/trigger/rabbitmq/trigger.go around lines 172-186 and inspect the linked commit context, focusing on the range-loop message reference and the analyzer's reassignment report. Compare the observed behavior with the range-loop finding descriptions, then leave the appropriate reaction classification; done means the finding is marked Bug, Mitigated, or Desirable Behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.