github-vet / github-vet/rangeloop-pointer-findings

yunionio/onecloud-operator: pkg/apis/onecloud/v1alpha1/zz_generated.deepcopy.go; 11 LoC

Open
#17,912 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [yunionio/onecloud-operator](https://www.github.com/yunionio/onecloud-operator) at [pkg/apis/onecloud/v1alpha1/zz_generated.deepcopy.go](https://github.com/yunionio/onecloud-operator/blob/5c64a80283cf1e1df2b9952cf4539de0b1cc9973/pkg/apis/onecloud/v1alpha1/zz_generated.deepcopy.go#L36-L46)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to val is reassigned at line 41

[Click here to see the code in its original context.](https://github.com/yunionio/onecloud-operator/blob/5c64a80283cf1e1df2b9952cf4539de0b1cc9973/pkg/apis/onecloud/v1alpha1/zz_generated.deepcopy.go#L36-L46)

Click here to show the 11 line(s) of Go which triggered the analyzer.

```go
for key, val := range *in {
var outVal *DeploymentStatus
if val == nil {
(*out)[key] = nil
} else {
in, out := &val, &outVal
*out = new(DeploymentStatus)
(*in).DeepCopyInto(*out)
}
(*out)[key] = outVal
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 5c64a80283cf1e1df2b9952cf4539de0b1cc9973

Contributor guide

No contributing guide indexed for this repository

Research direction

Read pkg/apis/onecloud/v1alpha1/zz_generated.deepcopy.go around lines 36-46 and inspect the reported range-loop reference behavior in context. Determine whether the analyzer finding is a real bug, mitigated, or desirable behavior, then apply the corresponding issue classification reaction; the issue is complete when that classification is supported by the code.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
infrastructure
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.