github-vet / github-vet/rangeloop-pointer-findings
realrainer/smppgate: smppworker.go; 21 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [realrainer/smppgate](https://www.github.com/realrainer/smppgate) at [smppworker.go](https://github.com/realrainer/smppgate/blob/78ef00cdc10378df61e34ade95503403f08dbd71/smppworker.go#L233-L253)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
>
[Click here to see the code in its original context.](https://github.com/realrainer/smppgate/blob/78ef00cdc10378df61e34ade95503403f08dbd71/smppworker.go#L233-L253)
Click here to show the 21 line(s) of Go which triggered the analyzer.
```go
for _, message := range messages {
if transceiver, err := w.GetTransceiver(); err == nil {
messageId, err := transceiver.SendMessage(message.From, message.Phone, message.Text)
if err == nil {
message.MessageId = messageId
message.Status = "sent"
w.db.Conn.Save(&message)
log.Printf("Info: SendMessage OK from=%q dest=%q text=%q\n", message.From, message.Phone, message.Text)
} else {
message.Status = "errored"
message.TryCount += 1
message.LastError = err.Error()
w.db.Conn.Save(&message)
log.Printf("Info: SendMessage ERROR: from=%q dest=%q text=%q: %s\n",
message.From, message.Phone, message.Text, err.Error())
break
}
} else {
log.Printf("Error: %s\n", err.Error())
}
}
```
Click here to show extra information the analyzer produced.
```
No path was found through the callgraph that could lead to a function which writes a pointer argument.
No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.
root signature {Save 1} was not found in the callgraph; reference was passed directly to third-party code
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 78ef00cdc10378df61e34ade95503403f08dbd71
Contributor guide
No contributing guide indexed for this repository
Research direction
Read smppworker.go lines 233-253 at commit 78ef00cdc10378df61e34ade95503403f08dbd71 and review the analyzer details; the issue does not include a message explaining the suspected problem. Done means leaving the requested reaction classifying the finding as Bug, Mitigated, or Desirable Behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100