github-vet / github-vet/rangeloop-pointer-findings

Freeaqingme/ClueGetter: src/cluegetter/bayes/bayes.go; 6 LoC

Open
#17,905 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [Freeaqingme/ClueGetter](https://www.github.com/Freeaqingme/ClueGetter) at [src/cluegetter/bayes/bayes.go](https://github.com/Freeaqingme/ClueGetter/blob/c378fbc31548df45e290537fc67e9561cbeebabe/src/cluegetter/bayes/bayes.go#L179-L184)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable module used in defer or goroutine at line 182

[Click here to see the code in its original context.](https://github.com/Freeaqingme/ClueGetter/blob/c378fbc31548df45e290537fc67e9561cbeebabe/src/cluegetter/bayes/bayes.go#L179-L184)

Click here to show the 6 line(s) of Go which triggered the analyzer.

```go
for _, module := range m.Modules() {
go func(m core.Module, msg *core.Message, isSpam bool) {
core.CluegetterRecover("bayesLearn." + m.Name())
module.BayesLearn(msg, isSpam)
}(module, msg, rpc.Bayes_Learn_Message.IsSpam)
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: c378fbc31548df45e290537fc67e9561cbeebabe

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reading src/cluegetter/bayes/bayes.go around lines 179-184 and the linked commit context. Check how the goroutine uses module versus the callback parameter, then classify the analyzer finding as Bug, Mitigated, or Desirable Behavior by leaving the corresponding reaction.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.