github-vet / github-vet/rangeloop-pointer-findings

oneinfra/oneinfra: apis/infra/v1alpha1/zz_generated.deepcopy.go; 23 LoC

Open
#17,884 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [oneinfra/oneinfra](https://www.github.com/oneinfra/oneinfra) at [apis/infra/v1alpha1/zz_generated.deepcopy.go](https://github.com/oneinfra/oneinfra/blob/37af1ef3827d56cbd4172185168b2fe7aa02c3c2/apis/infra/v1alpha1/zz_generated.deepcopy.go#L33-L55)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to val is reassigned at line 38

[Click here to see the code in its original context.](https://github.com/oneinfra/oneinfra/blob/37af1ef3827d56cbd4172185168b2fe7aa02c3c2/apis/infra/v1alpha1/zz_generated.deepcopy.go#L33-L55)

Click here to show the 23 line(s) of Go which triggered the analyzer.

```go
for key, val := range *in {
var outVal map[string]FileMap
if val == nil {
(*out)[key] = nil
} else {
in, out := &val, &outVal
*out = make(ComponentFileMap, len(*in))
for key, val := range *in {
var outVal map[string]string
if val == nil {
(*out)[key] = nil
} else {
in, out := &val, &outVal
*out = make(FileMap, len(*in))
for key, val := range *in {
(*out)[key] = val
}
}
(*out)[key] = outVal
}
}
(*out)[key] = outVal
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 37af1ef3827d56cbd4172185168b2fe7aa02c3c2

Contributor guide

No contributing guide indexed for this repository

Research direction

Read the surrounding code in apis/infra/v1alpha1/zz_generated.deepcopy.go at lines 33-55 and compare it with the linked original context at commit 37af1ef3827d56cbd4172185168b2fe7aa02c3c2. Determine whether the reported range-loop reference affects the deepcopy behavior, then leave the reaction corresponding to Bug, Mitigated, or Desirable Behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.