github-vet / github-vet/rangeloop-pointer-findings
TrashPony/Veliri: src/webSocket/lobby/get_details.go; 9 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [TrashPony/Veliri](https://www.github.com/TrashPony/Veliri) at [src/webSocket/lobby/get_details.go](https://github.com/TrashPony/Veliri/blob/54eea7a7c5fe778d23c47c486f8882bda8e31c9f/src/webSocket/lobby/get_details.go#L22-L30)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
>
[Click here to see the code in its original context.](https://github.com/TrashPony/Veliri/blob/54eea7a7c5fe778d23c47c486f8882bda8e31c9f/src/webSocket/lobby/get_details.go#L22-L30)
Click here to show the 9 line(s) of Go which triggered the analyzer.
```go
for i, resourceSlot := range userBase.CurrentResources {
userBase.GetRecyclePercent(resourceSlot.ItemID)
var newSlot inv.Slot
deepcopy.Copy(&newSlot, &resourceSlot)
userBaseResource[i] = &newSlot
userBaseResource[i].Quantity = userStorage.ViewQuantityItems(resourceSlot.ItemID, resourceSlot.Type)
}
```
Click here to show extra information the analyzer produced.
```
No path was found through the callgraph that could lead to a function which writes a pointer argument.
No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.
root signature {Copy 2} was not found in the callgraph; reference was passed directly to third-party code
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 54eea7a7c5fe778d23c47c486f8882bda8e31c9f
Contributor guide
No contributing guide indexed for this repository
Research direction
Read src/webSocket/lobby/get_details.go at commit 54eea7a7c5fe778d23c47c486f8882bda8e31c9f, focusing on the range loop, deepcopy.Copy call, and surrounding callers. Compare the behavior with the analyzer guidance linked in the issue; done means leaving the appropriate Bug, Mitigated, or Desirable Behavior reaction.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend, networking
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100