github-vet / github-vet/rangeloop-pointer-findings

VictoriaMetrics/operator: controllers/vmrule_controller.go; 31 LoC

Open
#17,856 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [VictoriaMetrics/operator](https://www.github.com/VictoriaMetrics/operator) at [controllers/vmrule_controller.go](https://github.com/VictoriaMetrics/operator/blob/41319bd3449a3422f77455551d5a01e6fa1d1d10/controllers/vmrule_controller.go#L73-L103)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to vmalert is reassigned at line 78

[Click here to see the code in its original context.](https://github.com/VictoriaMetrics/operator/blob/41319bd3449a3422f77455551d5a01e6fa1d1d10/controllers/vmrule_controller.go#L73-L103)

Click here to show the 31 line(s) of Go which triggered the analyzer.

```go
for _, vmalert := range alertMngs.Items {
if vmalert.DeletionTimestamp != nil {
continue
}
reqLogger.WithValues("vmalert", vmalert.Name)
currVMAlert := &vmalert
match, err := isVMAlertMatchesVMRule(currVMAlert, instance)
if err != nil {
reqLogger.Error(err, "cannot match vmalert and vmRule")
continue
}
// fast path, not match
if !match {
continue
}
reqLogger.Info("reconciling vmalert rules")
maps, err := factory.CreateOrUpdateRuleConfigMaps(ctx, currVMAlert, r)
if err != nil {
reqLogger.Error(err, "cannot update rules configmaps")
return ctrl.Result{}, err
}
reqLogger.Info("created rules maps count", "count", len(maps))

_, err = factory.CreateOrUpdateVMAlert(ctx, currVMAlert, r, r.BaseConf, maps)
if err != nil {
reqLogger.Error(err, "cannot trigger vmalert update, after rules changing")
return ctrl.Result{}, nil
}
reqLogger.Info("reconciled vmalert rules")

}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 41319bd3449a3422f77455551d5a01e6fa1d1d10

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.