github-vet / github-vet/rangeloop-pointer-findings

VictoriaMetrics/operator: controllers/vmprobe_controller.go; 23 LoC

Open
#17,855 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [VictoriaMetrics/operator](https://www.github.com/VictoriaMetrics/operator) at [controllers/vmprobe_controller.go](https://github.com/VictoriaMetrics/operator/blob/41319bd3449a3422f77455551d5a01e6fa1d1d10/controllers/vmprobe_controller.go#L71-L93)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to vmagent is reassigned at line 75

[Click here to see the code in its original context.](https://github.com/VictoriaMetrics/operator/blob/41319bd3449a3422f77455551d5a01e6fa1d1d10/controllers/vmprobe_controller.go#L71-L93)

Click here to show the 23 line(s) of Go which triggered the analyzer.

```go
for _, vmagent := range vmAgentInstances.Items {
if vmagent.DeletionTimestamp != nil {
continue
}
currentVMagent := &vmagent
reqLogger = reqLogger.WithValues("vmagent", vmagent.Name)
match, err := isVMAgentMatchesVMProbe(currentVMagent, instance)
if err != nil {
reqLogger.Error(err, "cannot match vmagent and vmProbe")
continue
}
// fast path
if !match {
continue
}
reqLogger.Info("reconciling probe for vmagent")
recon, err := factory.CreateOrUpdateVMAgent(ctx, currentVMagent, r, r.BaseConf)
if err != nil {
reqLogger.Error(err, "cannot create or update vmagent")
return recon, err
}
reqLogger.Info("reconciled vmagent")
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 41319bd3449a3422f77455551d5a01e6fa1d1d10

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.