github-vet / github-vet/rangeloop-pointer-findings

k11n/konstellation: api/v1alpha1/zz_generated.deepcopy.go; 13 LoC

Open
#17,851 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [k11n/konstellation](https://www.github.com/k11n/konstellation) at [api/v1alpha1/zz_generated.deepcopy.go](https://github.com/k11n/konstellation/blob/7abfd4134cde0737c5d2a3af8ad5ba82dd8c54e8/api/v1alpha1/zz_generated.deepcopy.go#L819-L831)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to val is reassigned at line 824

[Click here to see the code in its original context.](https://github.com/k11n/konstellation/blob/7abfd4134cde0737c5d2a3af8ad5ba82dd8c54e8/api/v1alpha1/zz_generated.deepcopy.go#L819-L831)

Click here to show the 13 line(s) of Go which triggered the analyzer.

```go
for key, val := range *in {
var outVal map[string]string
if val == nil {
(*out)[key] = nil
} else {
in, out := &val, &outVal
*out = make(ComponentConfig, len(*in))
for key, val := range *in {
(*out)[key] = val
}
}
(*out)[key] = outVal
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 7abfd4134cde0737c5d2a3af8ad5ba82dd8c54e8

Contributor guide

No contributing guide indexed for this repository

Research direction

Read api/v1alpha1/zz_generated.deepcopy.go at lines 819-831 and review the analyzer message about the reassigned range variable. Decide whether the reported instance is a Bug, Mitigated, or Desirable Behavior, then record that classification with the corresponding issue reaction.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
tooling
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.