kontrio/kappy: cmd/deploy.go; 68 LoC

Found a possible issue in [kontrio/kappy](https://www.github.com/kontrio/kappy) at [cmd/deploy.go](https://github.com/kontrio/kappy/blob/05030056792e7b32f787e3728cb11d03f75e837d/cmd/deploy.go#L45-L112)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to service was used in a composite literal at line 78

[Click here to see the code in its original context.](https://github.com/kontrio/kappy/blob/05030056792e7b32f787e3728cb11d03f75e837d/cmd/deploy.go#L45-L112)

Click here to show the 68 line(s) of Go which triggered the analyzer.

```go
for serviceName, service := range config.Services {
// TODO: refactor moving the key to the property.
service.Name = serviceName
namespace := stackDef.Namespace

serviceConfig, present := stackDef.Config[serviceName]

if present {
for _, containerConfig := range serviceConfig.ContainerConfig {
err := configureSecrets(client, serviceName, namespace, &containerConfig)

if err != nil {
log.Errorf("Failed to configure secrets for '%s' in the '%s' container", serviceName, containerConfig.Name)
log.Errorf("Error: %s", err)
os.Exit(1)
return
}
}
} else {
serviceConfig = model.ServiceConfig{}
}

// Create ingress for everything external
if !service.InternalOnly {
err := kubernetes.CreateUpdateIngress(client, &serviceConfig, serviceName, namespace)
if err != nil {
log.Errorf("Failed to create ingress: '%s'", serviceName)
log.Errorf("Error: %s", err)
os.Exit(1)
return
}
}

err := kubernetes.CreateUpdateService(client, &service, namespace)
if err != nil {
log.Errorf("Failed to create service: '%s'", serviceName)
log.Errorf("Error: %s", err)
os.Exit(1)
return
}

err = deployService(client, &service, &serviceConfig, namespace, DeployVersion, config.DockerRegistry)
if err != nil {
log.Errorf("Failed to deploy.. '%s'", serviceName)
log.Errorf("Error: %s", err)
os.Exit(1)
return
}

log.Infof("Watching deployment status - ctrl+c to cancel watch and continue..")
err = phase.NewPhase(context.Background()).
WithTimeout(1 * time.Minute).
CancelWithSignal(os.Interrupt).
Run(func(ctx context.Context) error {
return kubernetes.WatchDeployment(ctx, client, namespace, serviceName)
})

if err != nil {
log.Errorf("Failed to watch deployment.. '%s'", serviceName)
log.Errorf("Error: %s", err)
}

err = kubernetes.GetFailingPods(context.Background(), client, namespace, serviceName)
if err != nil {
log.Errorf("Failed to get pod statuses '%s'", serviceName)
log.Errorf("Error: %s", err)
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 05030056792e7b32f787e3728cb11d03f75e837d