github-vet / github-vet/rangeloop-pointer-findings
recovic/imitate-zhihu: service/QuestionService.go; 12 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [recovic/imitate-zhihu](https://www.github.com/recovic/imitate-zhihu) at [service/QuestionService.go](https://github.com/recovic/imitate-zhihu/blob/932e17aaf10729879dee0d96b4d24b0ed749ef6d/service/QuestionService.go#L20-L31)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
>
[Click here to see the code in its original context.](https://github.com/recovic/imitate-zhihu/blob/932e17aaf10729879dee0d96b4d24b0ed749ef6d/service/QuestionService.go#L20-L31)
Click here to show the 12 line(s) of Go which triggered the analyzer.
```go
for _, question := range questions {
res = cache.ReadQuestionCounts(&question)
if res.NotOK() {
return nil, res
}
questionDto := dto.QuestionShortDto{}
model.Copy(&questionDto, &question)
tool.CutContent(&questionDto.Content, 80)
questionDtos = append(questionDtos, questionDto)
}
```
Click here to show extra information the analyzer produced.
```
No path was found through the callgraph that could lead to a function which writes a pointer argument.
No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.
root signature {Copy 2} was not found in the callgraph; reference was passed directly to third-party code
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 932e17aaf10729879dee0d96b4d24b0ed749ef6d
Contributor guide
No contributing guide indexed for this repository
Research direction
Inspect service/QuestionService.go lines 20–31 at commit 932e17aaf10729879dee0d96b4d24b0ed749ef6d, focusing on the range-loop variable passed to cache.ReadQuestionCounts and model.Copy. Determine whether the analyzer finding is a Bug, Mitigated, or Desirable Behavior, then record that classification with the corresponding reaction.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100