github-vet / github-vet/rangeloop-pointer-findings

arteev/dsql: commands/db.go; 18 LoC

Open
#17,787 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [arteev/dsql](https://www.github.com/arteev/dsql) at [commands/db.go](https://github.com/arteev/dsql/blob/854da8cb02215cb473010ec732d195800c167993/commands/db.go#L164-L181)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to curdb was used in a composite literal at line 167

[Click here to see the code in its original context.](https://github.com/arteev/dsql/blob/854da8cb02215cb473010ec732d195800c167993/commands/db.go#L164-L181)

Click here to show the 18 line(s) of Go which triggered the analyzer.

```go
for _, curdb := range dbs {
logger.Trace.Printf("process tag: %q\n", curdb.Code)

cnt, err := d.AddTags(&curdb, add...)
if err != nil {
return err
}
cntadd += cnt
logger.Info.Printf("Added tags %d for %s\n", cnt, curdb.Code)

cnt, err = d.RemoveTags(&curdb, remove...)
if err != nil {
return err
}
cntremove += cnt
logger.Info.Printf("Removed tags %d for %s\n", cnt, curdb.Code)

}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 854da8cb02215cb473010ec732d195800c167993

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reading commands/db.go lines 164-181 and the linked code context; inspect how AddTags and RemoveTags use the referenced value. Done means determining whether the reported range-loop reference is a real bug and recording a clear Bug, Mitigated, or Desirable Behavior classification.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.