github-vet / github-vet/rangeloop-pointer-findings
milosgajdos/vaultops: command/unseal.go; 38 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [milosgajdos/vaultops](https://www.github.com/milosgajdos/vaultops) at [command/unseal.go](https://github.com/milosgajdos/vaultops/blob/877ff3d34ab15c977999b88bcf22c7dcae5a6b26/command/unseal.go#L153-L190)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable host used in defer or goroutine at line 165
[Click here to see the code in its original context.](https://github.com/milosgajdos/vaultops/blob/877ff3d34ab15c977999b88bcf22c7dcae5a6b26/command/unseal.go#L153-L190)
Click here to show the 38 line(s) of Go which triggered the analyzer.
```go
for _, host := range hosts {
v, err := c.Client(host, vk.RootToken)
if err != nil {
c.UI.Error(fmt.Sprintf("Failed to fetch Vault client: %v", err))
return 1
}
go func(h string) {
// check status and send down the status channel
resp, err := v.Sys().SealStatus()
if err != nil {
c.UI.Error(fmt.Sprintf("Failed to read seal status of %s: %v", h, err))
statChan <- &res{host: h, resp: resp, err: err}
return
}
// if the host is unsealed, don't do anything
if !resp.Sealed {
statChan <- &res{host: h, resp: resp, err: err}
return
}
// if unseal threshold is bigger than the number of supplied master keys
// we only attempt len(keys) unseals
t := resp.T
if t > len(vk.MasterKeys) {
t = len(vk.MasterKeys)
}
// attempt to unseal vault nodes with all the keys; bail on error
// otherwise we return the latest unseal response
c.UI.Info(fmt.Sprintf("Attempting to unseal host: %s", h))
for i := 0; i < t; i++ {
resp, err = v.Sys().Unseal(vk.MasterKeys[i])
if err != nil {
break
}
}
statChan <- &res{host: h, resp: resp, err: err}
}(host)
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 877ff3d34ab15c977999b88bcf22c7dcae5a6b26
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.