github-vet / github-vet/rangeloop-pointer-findings

tencentcloudstack/terraform-provider-tencentcloud: tencentcloud/service_tencentcloud_tcr.go; 4 LoC

Open
#17,717 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [tencentcloudstack/terraform-provider-tencentcloud](https://www.github.com/tencentcloudstack/terraform-provider-tencentcloud) at [tencentcloud/service_tencentcloud_tcr.go](https://github.com/tencentcloudstack/terraform-provider-tencentcloud/blob/b45a4853d49f97886efcd74f06afe4db40a75f2a/tencentcloud/service_tencentcloud_tcr.go#L32-L35)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to v was used in a composite literal at line 33

[Click here to see the code in its original context.](https://github.com/tencentcloudstack/terraform-provider-tencentcloud/blob/b45a4853d49f97886efcd74f06afe4db40a75f2a/tencentcloud/service_tencentcloud_tcr.go#L32-L35)

Click here to show the 4 line(s) of Go which triggered the analyzer.

```go
for k, v := range tags {
tag := tcr.Tag{Value: &v, Key: &k}
tagSpec.Tags = append(tagSpec.Tags, &tag)
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: b45a4853d49f97886efcd74f06afe4db40a75f2a

Contributor guide

No contributing guide indexed for this repository

Research direction

Inspect tencentcloud/service_tencentcloud_tcr.go at lines 32-35 and review the analyzer's range-variable reference finding in context. Determine whether the finding is a Bug, Mitigated, or Desirable Behavior, then record that classification with the corresponding issue reaction.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, terraform
Domain
cloud, infrastructure
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.