github-vet / github-vet/rangeloop-pointer-findings

hello-mr-code/terraform-oci: oci/datacatalog_catalog_resource.go; 17 LoC

Open
#17,681 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [hello-mr-code/terraform-oci](https://www.github.com/hello-mr-code/terraform-oci) at [oci/datacatalog_catalog_resource.go](https://github.com/hello-mr-code/terraform-oci/blob/2f6aa93ef8643328af454512a5fe78ab006697f0/oci/datacatalog_catalog_resource.go#L539-L555)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to attachCatalogPrivateEndpoint is reassigned at line 542

[Click here to see the code in its original context.](https://github.com/hello-mr-code/terraform-oci/blob/2f6aa93ef8643328af454512a5fe78ab006697f0/oci/datacatalog_catalog_resource.go#L539-L555)

Click here to show the 17 line(s) of Go which triggered the analyzer.

```go
for _, attachCatalogPrivateEndpoint := range attachCatalogPrivateEndpoints {
catalogId := s.D.Id()
request := oci_datacatalog.AttachCatalogPrivateEndpointRequest{}
request.CatalogPrivateEndpointId = &attachCatalogPrivateEndpoint
request.CatalogId = &catalogId
request.RequestMetadata.RetryPolicy = getRetryPolicy(s.DisableNotFoundRetries, "datacatalog")

response, err := s.Client.AttachCatalogPrivateEndpoint(context.Background(), request)
if err != nil {
return err
}
workId := response.OpcWorkRequestId

// Wait until update finishes
_, err = catalogWaitForWorkRequest(workId, "catalog",
oci_datacatalog.WorkRequestResourceActionTypeUpdated, s.D.Timeout(schema.TimeoutUpdate), s.DisableNotFoundRetries, s.Client)
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 2f6aa93ef8643328af454512a5fe78ab006697f0

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.