github-vet / github-vet/rangeloop-pointer-findings
donnie4w/gdao: example/dao/hstest.go; 8 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [donnie4w/gdao](https://www.github.com/donnie4w/gdao) at [example/dao/hstest.go](https://github.com/donnie4w/gdao/blob/08940c89571adf687e5c60edc528e6c1bf057ecf/example/dao/hstest.go#L162-L169)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> reference to core was used in a composite literal at line 168
[Click here to see the code in its original context.](https://github.com/donnie4w/gdao/blob/08940c89571adf687e5c60edc528e6c1bf057ecf/example/dao/hstest.go#L162-L169)
Click here to show the 8 line(s) of Go which triggered the analyzer.
```go
for j, core := range rows {
if core == nil {
continue
}
field := columns[j].Name()
setfield := "Set" + gdao.ToUpperFirstLetter(field)
reflect.ValueOf(t).MethodByName(setfield).Call([]reflect.Value{reflect.ValueOf(gdao.GetValue(&core))})
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 08940c89571adf687e5c60edc528e6c1bf057ecf
Contributor guide
No contributing guide indexed for this repository
Research direction
Review example/dao/hstest.go lines 162-169, starting with the range loop and the reference passed to gdao.GetValue. Determine whether the analyzer warning is a bug, mitigation, or desirable behavior, then inspect the surrounding DAO behavior before deciding what change or classification is appropriate.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100