pachyderm/pachyderm: src/client/pkg/shard/sharder.go; 31 LoC

Found a possible issue in [pachyderm/pachyderm](https://www.github.com/pachyderm/pachyderm) at [src/client/pkg/shard/sharder.go](https://github.com/pachyderm/pachyderm/blob/681aba241c06eef549643e1a32eb6cbd07e6f1c9/src/client/pkg/shard/sharder.go#L698-L728)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to serverRole was used in a composite literal at line 723

[Click here to see the code in its original context.](https://github.com/pachyderm/pachyderm/blob/681aba241c06eef549643e1a32eb6cbd07e6f1c9/src/client/pkg/shard/sharder.go#L698-L728)

Click here to show the 31 line(s) of Go which triggered the analyzer.

```go
for version, serverRole := range oldRoles {
var wg sync.WaitGroup
var removeShardErr error
if _, ok := roles[version]; ok {
// these roles haven't expired yet, so nothing to do
continue
}
for _, shard := range shards(serverRole) {
if !containsShard(roles, shard) {
shard := shard
for _, server := range servers {
server := server
wg.Add(1)
go func(shard uint64) {
defer wg.Done()
if err := server.DeleteShard(shard); err != nil && removeShardErr == nil {
removeShardErr = err
}
}(shard)
}
}
}
wg.Wait()
if removeShardErr != nil {
log.Error(&RemoveServerRole{
ServerRole: &serverRole,
Error: removeShardErr.Error(),
})
return removeShardErr
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 681aba241c06eef549643e1a32eb6cbd07e6f1c9