github-vet / github-vet/rangeloop-pointer-findings

tangfeixiong/go-to-docker: metering/pkg/exporter/cadvisor.go; 12 LoC

Open
#17,646 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [tangfeixiong/go-to-docker](https://www.github.com/tangfeixiong/go-to-docker) at [metering/pkg/exporter/cadvisor.go](https://github.com/tangfeixiong/go-to-docker/blob/f4cebfc611b1516f3b29db93025e272368a2d88c/metering/pkg/exporter/cadvisor.go#L66-L77)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable v used in defer or goroutine at line 70

[Click here to see the code in its original context.](https://github.com/tangfeixiong/go-to-docker/blob/f4cebfc611b1516f3b29db93025e272368a2d88c/metering/pkg/exporter/cadvisor.go#L66-L77)

Click here to show the 12 line(s) of Go which triggered the analyzer.

```go
for k, v := range cm.jobs {
wg.Add(1)
go func() {
defer wg.Done()
v.result, v.Err = cm.ReapMetrics(k)
if cm.clientrpc != nil {
cm.clientrpc.Transit(v.result)
}
v.LastUpdated = time.Now()
resp[k] = *v
}()
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: f4cebfc611b1516f3b29db93025e272368a2d88c

Contributor guide

No contributing guide indexed for this repository

Research direction

Read metering/pkg/exporter/cadvisor.go lines 66-77 at commit f4cebfc611b1516f3b29db93025e272368a2d88c, focusing on the range loop and goroutine that uses k and v. Determine whether the analyzer warning represents a bug, mitigated behavior, or desirable behavior, then leave the corresponding reaction on the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.