github-vet / github-vet/rangeloop-pointer-findings
sourcegraph/sourcegraph: internal/cmd/precise-code-intel-tester/upload.go; 21 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [sourcegraph/sourcegraph](https://www.github.com/sourcegraph/sourcegraph) at [internal/cmd/precise-code-intel-tester/upload.go](https://github.com/sourcegraph/sourcegraph/blob/ea59d30ed142079cad0d6dae111a4f3b81991725/internal/cmd/precise-code-intel-tester/upload.go#L238-L258)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable rev used in defer or goroutine at line 248
[Click here to see the code in its original context.](https://github.com/sourcegraph/sourcegraph/blob/ea59d30ed142079cad0d6dae111a4f3b81991725/internal/cmd/precise-code-intel-tester/upload.go#L238-L258)
Click here to show the 21 line(s) of Go which triggered the analyzer.
```go
for i, rev := range revs {
id, err := upload(ctx, name, i, rev, limiter)
if err != nil {
return err
}
atomic.AddUint32(&numUploaded, 1)
wg.Add(1)
go func() {
defer wg.Done()
ch <- <-processedSignals[name][rev]
}()
select {
// send id to monitor
case uploaded <- Upload{Name: name, Index: i, Rev: rev, UploadID: id}:
case <-ctx.Done():
return ctx.Err()
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: ea59d30ed142079cad0d6dae111a4f3b81991725
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.