github-vet / github-vet/rangeloop-pointer-findings
Yenchu/eks-demo: awsapi/sqs.go; 18 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [Yenchu/eks-demo](https://www.github.com/Yenchu/eks-demo) at [awsapi/sqs.go](https://github.com/Yenchu/eks-demo/blob/1c926c8efbe8b87d059c86a8022facda5fe8be73/awsapi/sqs.go#L75-L92)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
>
[Click here to see the code in its original context.](https://github.com/Yenchu/eks-demo/blob/1c926c8efbe8b87d059c86a8022facda5fe8be73/awsapi/sqs.go#L75-L92)
Click here to show the 18 line(s) of Go which triggered the analyzer.
```go
for _, sqsMsg := range resp.Messages {
wg.Add(1)
go func(m *sqs.Message) {
defer wg.Done()
err = msgHandler(aws.StringValue(m.Body))
if err != nil {
fmt.Printf("handle message failed: %v\n", err)
return
}
err = api.deleteMessage(queueUrl, m)
if err != nil {
fmt.Printf("delete message failed: %v\n", err)
}
}(&sqsMsg)
}
```
Click here to show extra information the analyzer produced.
```
No path was found through the callgraph that could lead to a function which writes a pointer argument.
No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.
root signature { 1} was not found in the callgraph; reference was passed directly to third-party code
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 1c926c8efbe8b87d059c86a8022facda5fe8be73
Contributor guide
No contributing guide indexed for this repository
Research direction
Read awsapi/sqs.go lines 75-92 and the analyzer context, then compare the pointer capture with Go range-loop semantics and the SQS message flow. Confirm whether the finding is a bug, mitigated, or desirable behavior, and leave the corresponding reaction on the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100