github-vet / github-vet/rangeloop-pointer-findings

mozillazg/snippets: git/hooks/github/hook.go; 25 LoC

Open
#17,632 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [mozillazg/snippets](https://www.github.com/mozillazg/snippets) at [git/hooks/github/hook.go](https://github.com/mozillazg/snippets/blob/4fd6cabd234d62372e9c3e765d1790b0e6543f42/git/hooks/github/hook.go#L45-L69)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable value used in defer or goroutine at line 49

[Click here to see the code in its original context.](https://github.com/mozillazg/snippets/blob/4fd6cabd234d62372e9c3e765d1790b0e6543f42/git/hooks/github/hook.go#L45-L69)

Click here to show the 25 line(s) of Go which triggered the analyzer.

```go
for repoName, value := range config.Get("hooks").MustMap() {
if repo == repoName {
log.Printf("match repo: %s\n", repo)
go func() {
valueMap, _ := value.(map[string]interface{})
cmd, _ := valueMap["cmd"]

script := []string{}
switch vv := cmd.(type) {
case []interface{}:
for _, v := range vv {
s, _ := v.(string)
script = append(script, s)
}
case interface{}:
s, _ := vv.(string)
script = append(script, s)
}

log.Printf("script: %s\n", script)
runcmd("/bin/bash", script...)
}()
break
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 4fd6cabd234d62372e9c3e765d1790b0e6543f42

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.