github-vet / github-vet/rangeloop-pointer-findings
monkeybutter/xtrss_thredds: xtrss_thredds.go; 22 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [monkeybutter/xtrss_thredds](https://www.github.com/monkeybutter/xtrss_thredds) at [xtrss_thredds.go](https://github.com/monkeybutter/xtrss_thredds/blob/1b57b925420a5d67c96d80fcf77e6712e5a7123e/xtrss_thredds.go#L15-L36)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable url used in defer or goroutine at line 20
[Click here to see the code in its original context.](https://github.com/monkeybutter/xtrss_thredds/blob/1b57b925420a5d67c96d80fcf77e6712e5a7123e/xtrss_thredds.go#L15-L36)
Click here to show the 22 line(s) of Go which triggered the analyzer.
```go
for url := range buf {
if verbose {
fmt.Println(url)
}
go func() {
resp, err := http.Get(url)
if err != nil {
log.Printf("Error doing GET: %s\n", err)
return
}
defer resp.Body.Close()
body, err := ioutil.ReadAll(resp.Body)
if err != nil {
log.Printf("Error reading HTTP body: %s\n", err)
return
}
totalBytes.Add(len(body))
totalReqs.Add(1)
}()
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 1b57b925420a5d67c96d80fcf77e6712e5a7123e
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.