github-vet / github-vet/rangeloop-pointer-findings

myitcv/x: cmd/egrunner/main.go; 26 LoC

Open
#17,594 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [myitcv/x](https://www.github.com/myitcv/x) at [cmd/egrunner/main.go](https://github.com/myitcv/x/blob/a7167afc9e13880295c3494d3354c800dbc34351/cmd/egrunner/main.go#L326-L351)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to c is reassigned at line 330

[Click here to see the code in its original context.](https://github.com/myitcv/x/blob/a7167afc9e13880295c3494d3354c800dbc34351/cmd/egrunner/main.go#L326-L351)

Click here to show the 26 line(s) of Go which triggered the analyzer.

```go
for _, c := range s.Comments {
if start == nil {
if s.Pos().After(c.End()) {
if strings.TrimSpace(c.Text) == commentStart {
start = &c
}
}
}

// commBlock != nil indicates we have started adding comments to a block
// The end of the block is makred by a blank line.

// Work out whether we have passed a blank line.
if c.Pos().Line() > lastNonBlank+1 {
if err := process(commBlock); err != nil {
return err
}
commBlock = make([]syntax.Comment, 0)
}

if commBlock != nil {
// this comment is contiguous with last in existing comment
commBlock = append(commBlock, c)
}
lastNonBlank = c.End().Line()
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: a7167afc9e13880295c3494d3354c800dbc34351

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.