github-vet / github-vet/rangeloop-pointer-findings

sohlich/healthcheck: healthcheck.go; 5 LoC

Open
#17,574 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [sohlich/healthcheck](https://www.github.com/sohlich/healthcheck) at [healthcheck.go](https://github.com/sohlich/healthcheck/blob/c7ccc11025031c0d5b108ce452bd221821d0343f/healthcheck.go#L126-L130)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable hook used in defer or goroutine at line 128

[Click here to see the code in its original context.](https://github.com/sohlich/healthcheck/blob/c7ccc11025031c0d5b108ce452bd221821d0343f/healthcheck.go#L126-L130)

Click here to show the 5 line(s) of Go which triggered the analyzer.

```go
for _, hook := range ch.hooks {
go func(r map[string]bool) {
hook(r)
}(res)
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: c7ccc11025031c0d5b108ce452bd221821d0343f

Contributor guide

No contributing guide indexed for this repository

Research direction

Read healthcheck.go lines 126-130 at commit c7ccc11025031c0d5b108ce452bd221821d0343f, then review the linked classification guidance. Decide whether the range-loop variable capture in the goroutine is a bug, mitigated, or desirable behavior, and leave the corresponding reaction; no code change is specified.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.