github-vet / github-vet/rangeloop-pointer-findings

Wouterbeets/snake: game.go; 7 LoC

Open
#17,572 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [Wouterbeets/snake](https://www.github.com/Wouterbeets/snake) at [game.go](https://github.com/Wouterbeets/snake/blob/aca83a5095dcf51742ee9553ea4ec2dc2d4db6d2/game.go#L83-L89)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable i used in defer or goroutine at line 87

[Click here to see the code in its original context.](https://github.com/Wouterbeets/snake/blob/aca83a5095dcf51742ee9553ea4ec2dc2d4db6d2/game.go#L83-L89)

Click here to show the 7 line(s) of Go which triggered the analyzer.

```go
for i := range g.Players {
wg.Add(1)
go func() {
defer wg.Done()
cmove <- g.Players[i].Play(g)
}()
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: aca83a5095dcf51742ee9553ea4ec2dc2d4db6d2

Contributor guide

No contributing guide indexed for this repository

Research direction

Read game.go at lines 83-89 and inspect how the range-loop index is used inside the goroutine. Compare the analyzer finding with the surrounding game logic, then classify it as Bug, Mitigated, or Desirable Behavior using the linked project guidance and leave the corresponding reaction.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.