github-vet / github-vet/rangeloop-pointer-findings

Factom-Asset-Tokens/fatd: cli/gettransactions.go; 9 LoC

Open
#17,565 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [Factom-Asset-Tokens/fatd](https://www.github.com/Factom-Asset-Tokens/fatd) at [cli/gettransactions.go](https://github.com/Factom-Asset-Tokens/fatd/blob/f8331d1d63aad652e6ae481475458bb57a037f5b/cli/gettransactions.go#L202-L210)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to txID is reassigned at line 204

[Click here to see the code in its original context.](https://github.com/Factom-Asset-Tokens/fatd/blob/f8331d1d63aad652e6ae481475458bb57a037f5b/cli/gettransactions.go#L202-L210)

Click here to show the 9 line(s) of Go which triggered the analyzer.

```go
for _, txID := range transactionIDs {
vrbLog.Printf("Fetching tx details... %v", txID)
params.Hash = &txID
if err := FATClient.Request(context.Background(),
"get-transaction", params, &result); err != nil {
errLog.Fatal(err)
}
printTx(result)
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: f8331d1d63aad652e6ae481475458bb57a037f5b

Contributor guide

No contributing guide indexed for this repository

Research direction

Inspect cli/gettransactions.go at lines 202-210 and review how the transaction request uses params.Hash inside the loop. Run the repository's available tests or checks and confirm that each transaction request uses the intended transaction ID without the reported analyzer finding.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.