github-vet / github-vet/rangeloop-pointer-findings

driusan/dgit: git/packobjects.go; 22 LoC

Open
#17,555 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [driusan/dgit](https://www.github.com/driusan/dgit) at [git/packobjects.go](https://github.com/driusan/dgit/blob/df0293e1c8bb4c484a2ca1790567a270d65016a6/git/packobjects.go#L72-L93)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to tryobj is reassigned at line 88

[Click here to see the code in its original context.](https://github.com/driusan/dgit/blob/df0293e1c8bb4c484a2ca1790567a270d65016a6/git/packobjects.go#L72-L93)

Click here to show the 22 line(s) of Go which triggered the analyzer.

```go
for _, tryobj := range window {
basebytes := tryobj.cache
if tryobj.typ != otypreal {
continue
}

var newdelta bytes.Buffer
if err := delta.CalculateWithIndex(tryobj.index, &newdelta, basebytes, objbytes, len(best)/2); err == nil {

if d := newdelta.Bytes(); len(d) < len(best) {
best = d
if opts.DeltaBaseOffset {
otyp = OBJ_OFS_DELTA
} else {
otyp = OBJ_REF_DELTA
}
ref = &tryobj
}
} else {
log.Println(err)
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: df0293e1c8bb4c484a2ca1790567a270d65016a6

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.