github-vet / github-vet/rangeloop-pointer-findings
dmittelstaedt/dpwdss: client/cmd/getPermissions.go; 4 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [dmittelstaedt/dpwdss](https://www.github.com/dmittelstaedt/dpwdss) at [client/cmd/getPermissions.go](https://github.com/dmittelstaedt/dpwdss/blob/0892f7218cf136d515f5de4833e2313c0d3e34b2/client/cmd/getPermissions.go#L128-L131)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> reference to permission was used in a composite literal at line 129
[Click here to see the code in its original context.](https://github.com/dmittelstaedt/dpwdss/blob/0892f7218cf136d515f5de4833e2313c0d3e34b2/client/cmd/getPermissions.go#L128-L131)
Click here to show the 4 line(s) of Go which triggered the analyzer.
```go
for _, permission := range permissions {
permissionOut := logic.ConvertPermissions(&permission)
permissionsOut = append(permissionsOut, permissionOut)
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 0892f7218cf136d515f5de4833e2313c0d3e34b2
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with client/cmd/getPermissions.go at lines 128-131 and inspect how ConvertPermissions uses the referenced permission. Determine whether taking the address of the range variable can produce incorrect results, then compare the behavior with the analyzer’s warning. Done means classifying the finding as a bug, mitigated issue, or desirable behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100