github-vet / github-vet/rangeloop-pointer-findings

ThomasVNN/Go_skeleton: repo/shop_service_client.go; 5 LoC

Open
#17,501 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [ThomasVNN/Go_skeleton](https://www.github.com/ThomasVNN/Go_skeleton) at [repo/shop_service_client.go](https://github.com/ThomasVNN/Go_skeleton/blob/ebb2bf08d29fecd5ef670747a79bd0b091c0ffc2/repo/shop_service_client.go#L69-L73)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to item is reassigned at line 71

[Click here to see the code in its original context.](https://github.com/ThomasVNN/Go_skeleton/blob/ebb2bf08d29fecd5ef670747a79bd0b091c0ffc2/repo/shop_service_client.go#L69-L73)

Click here to show the 5 line(s) of Go which triggered the analyzer.

```go
for _, item := range resp.Data {
if _, ok := mapResp[item.Id]; !ok {
mapResp[item.Id] = &item
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: ebb2bf08d29fecd5ef670747a79bd0b091c0ffc2

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in repo/shop_service_client.go at the loop around lines 69-73, then inspect how mapResp is consumed and whether its stored pointers must remain distinct. Confirm the intended behavior for each response item and add or run focused checks for that behavior; done means the analyzer finding is resolved without changing the client’s expected results.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
api
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.