github-vet / github-vet/rangeloop-pointer-findings
mmussomele/quilt: cluster/amazon/amazon.go; 32 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [mmussomele/quilt](https://www.github.com/mmussomele/quilt) at [cluster/amazon/amazon.go](https://github.com/mmussomele/quilt/blob/5ff444e46d4f7067d2c927277351f53064271acc/cluster/amazon/amazon.go#L102-L133)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> reference to count was used in a composite literal at line 121
[Click here to see the code in its original context.](https://github.com/mmussomele/quilt/blob/5ff444e46d4f7067d2c927277351f53064271acc/cluster/amazon/amazon.go#L102-L133)
Click here to show the 32 line(s) of Go which triggered the analyzer.
```go
for br, count := range bootReqMap {
groupID, _, err := clst.getCreateSecurityGroup()
if err != nil {
return err
}
cloudConfig64 := base64.StdEncoding.EncodeToString([]byte(br.cfg))
resp, err := clst.client.RequestSpotInstances(
&ec2.RequestSpotInstancesInput{
SpotPrice: aws.String(spotPrice),
LaunchSpecification: &ec2.RequestSpotLaunchSpecification{
ImageId: aws.String(amis[clst.region]),
InstanceType: aws.String(br.size),
UserData: &cloudConfig64,
SecurityGroupIds: []*string{aws.String(groupID)},
BlockDeviceMappings: []*ec2.BlockDeviceMapping{
blockDevice(br.diskSize),
},
},
InstanceCount: &count,
})
if err != nil {
return err
}
for _, request := range resp.SpotInstanceRequests {
awsIDs = append(awsIDs, awsID{
spotID: *request.SpotInstanceRequestId,
region: clst.region})
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 5ff444e46d4f7067d2c927277351f53064271acc
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.