github-vet / github-vet/rangeloop-pointer-findings

Yesterday17/bili-archive: main.go; 13 LoC

Open
#17,493 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [Yesterday17/bili-archive](https://www.github.com/Yesterday17/bili-archive) at [main.go](https://github.com/Yesterday17/bili-archive/blob/26d66f02c8af7bf250819f568c70680241a75615/main.go#L155-L167)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to item is reassigned at line 156

[Click here to see the code in its original context.](https://github.com/Yesterday17/bili-archive/blob/26d66f02c8af7bf250819f568c70680241a75615/main.go#L155-L167)

Click here to show the 13 line(s) of Go which triggered the analyzer.

```go
for _, item := range items {
videoMap[strconv.Itoa(item.AID)] = &item
videos = append(videos, item)

status := DownloadStatus{
ui: nil,
pg: nil,
st: nil,
status: "等待下载",
active: false,
}
videoStatusMap[strconv.Itoa(item.AID)] = &status
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 26d66f02c8af7bf250819f568c70680241a75615

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with main.go lines 155-167 at commit 26d66f02c8af7bf250819f568c70680241a75615 and inspect how references stored in videoMap are used. Check whether each entry refers to its intended item and whether the analyzer finding is valid; done means the range-loop pointer issue is resolved or documented as mitigated without changing the intended video mapping.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.