github-vet / github-vet/rangeloop-pointer-findings

evandigby/nesgo: ppu/websocketrenderer.go; 6 LoC

Open
#17,490 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [evandigby/nesgo](https://www.github.com/evandigby/nesgo) at [ppu/websocketrenderer.go](https://github.com/evandigby/nesgo/blob/ea41a2c25789e74527c98b574232043ad622dbbd/ppu/websocketrenderer.go#L73-L78)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable conn used in defer or goroutine at line 76

[Click here to see the code in its original context.](https://github.com/evandigby/nesgo/blob/ea41a2c25789e74527c98b574232043ad622dbbd/ppu/websocketrenderer.go#L73-L78)

Click here to show the 6 line(s) of Go which triggered the analyzer.

```go
for _, conn := range ws.conns {
go func() {
defer wg.Done()
conn.WriteMessage(websocket.TextMessage, base64img)
}()
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: ea41a2c25789e74527c98b574232043ad622dbbd

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at ppu/websocketrenderer.go lines 73-78 and inspect how the range variable is used by the goroutine. Compare the analyzer warning with the intended connection behavior, then classify the finding as a bug, mitigated, or desirable behavior; no test or patch target is named in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
networking
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.