github-vet / github-vet/rangeloop-pointer-findings

sensu/sensu-aws: plugins/s3/check-s3-bucket-visibility/main.go; 3 LoC

Open
#17,476 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [sensu/sensu-aws](https://www.github.com/sensu/sensu-aws) at [plugins/s3/check-s3-bucket-visibility/main.go](https://github.com/sensu/sensu-aws/blob/74db29abe13d69389d8d27e65b7532fb561de5cb/plugins/s3/check-s3-bucket-visibility/main.go#L133-L135)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to bucket is reassigned at line 134

[Click here to see the code in its original context.](https://github.com/sensu/sensu-aws/blob/74db29abe13d69389d8d27e65b7532fb561de5cb/plugins/s3/check-s3-bucket-visibility/main.go#L133-L135)

Click here to show the 3 line(s) of Go which triggered the analyzer.

```go
for _, bucket := range bucketsTobeExcluded {
excludeBucketsMap[bucket] = &bucket
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 74db29abe13d69389d8d27e65b7532fb561de5cb

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at plugins/s3/check-s3-bucket-visibility/main.go lines 133-135 and read how excludeBucketsMap is used. Verify the analyzer finding against the loop's pointer behavior, then run the repository's relevant Go checks. Done means excluded buckets retain the intended values without the reported range-variable issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cloud
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.