github-vet / github-vet/rangeloop-pointer-findings

GeoNet/delta: tools/sit/main.go; 33 LoC

Open
#17,460 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [GeoNet/delta](https://www.github.com/GeoNet/delta) at [tools/sit/main.go](https://github.com/GeoNet/delta/blob/ba278a9e9009689a0a3bd72691be1f064a6b0d1f/tools/sit/main.go#L356-L388)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to m is reassigned at line 385

[Click here to see the code in its original context.](https://github.com/GeoNet/delta/blob/ba278a9e9009689a0a3bd72691be1f064a6b0d1f/tools/sit/main.go#L356-L388)

Click here to show the 33 line(s) of Go which triggered the analyzer.

```go
for _, m := range markList {

im := make([]*sit_delta_pb.InstalledMonument, 0)

list := monuments[m.Code]
for _, l := range list {
newMonument := sit_delta_pb.InstalledMonument{
Span: &sit_delta_pb.Span{
Start: l.Start.Unix(),
End: l.End.Unix(),
},
Monument: &sit_delta_pb.Monument{
DomesNumber: l.DomesNumber,
Height: l.GroundRelationship,
},
}
im = append(im, &newMonument)
}

mark := sit_delta_pb.Mark{
InstalledMonument: im,
Point: &sit_delta_pb.Point{
Longitude: m.Longitude,
Latitude: m.Latitude,
Elevation: m.Elevation,
Datum: m.Datum,
},
}

markMap[m.Code] = &m
siteCodeList = append(siteCodeList, m.Code)
sitMarkList[m.Code] = &mark
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: ba278a9e9009689a0a3bd72691be1f064a6b0d1f

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at tools/sit/main.go lines 356-388 and inspect how the range-loop variable m is used, especially the assignment at line 385. Compare the analyzer warning with the surrounding behavior and project context; done means determining whether the finding is a Bug, Mitigated, or Desirable Behavior and recording the evidence.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.