github-vet / github-vet/rangeloop-pointer-findings

arider/goBN: bayesiannetwork/bayesianNetwork.go; 19 LoC

Open
#17,459 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [arider/goBN](https://www.github.com/arider/goBN) at [bayesiannetwork/bayesianNetwork.go](https://github.com/arider/goBN/blob/1be0c7f9ce745ef9d877b6f678f3ca46a9b739d2/bayesiannetwork/bayesianNetwork.go#L206-L224)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable instance used in defer or goroutine at line 214

[Click here to see the code in its original context.](https://github.com/arider/goBN/blob/1be0c7f9ce745ef9d877b6f678f3ca46a9b739d2/bayesiannetwork/bayesianNetwork.go#L206-L224)

Click here to show the 19 line(s) of Go which triggered the analyzer.

```go
for index, instance := range observations {
likelihoods[index] = 1.0

wg.Add(1)
go func() {
defer wg.Done()

for _, n := range net.Nodes {
State := instance[n]
parentStates := make(map[*Node]int)
for _, parent := range n.Parents {
parentStates[parent] = instance[parent]
}
cpd_index := n.getCPDIndex(parentStates)
likelihoods[index] *= n.cpd[cpd_index].StateMap[State]
}
}()
wg.Wait()
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 1be0c7f9ce745ef9d877b6f678f3ca46a9b739d2

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.