github-vet / github-vet/rangeloop-pointer-findings
openshift/cluster-logging-operator: pkg/apis/logging/v1/zz_generated.deepcopy.go; 13 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [openshift/cluster-logging-operator](https://www.github.com/openshift/cluster-logging-operator) at [pkg/apis/logging/v1/zz_generated.deepcopy.go](https://github.com/openshift/cluster-logging-operator/blob/941a91a263af8c243bfb805ea3115c3001e0d8a2/pkg/apis/logging/v1/zz_generated.deepcopy.go#L646-L658)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> reference to val is reassigned at line 651
[Click here to see the code in its original context.](https://github.com/openshift/cluster-logging-operator/blob/941a91a263af8c243bfb805ea3115c3001e0d8a2/pkg/apis/logging/v1/zz_generated.deepcopy.go#L646-L658)
Click here to show the 13 line(s) of Go which triggered the analyzer.
```go
for key, val := range *in {
var outVal []loggingv1.ClusterCondition
if val == nil {
(*out)[key] = nil
} else {
in, out := &val, &outVal
*out = make(ElasticsearchClusterConditions, len(*in))
for i := range *in {
(*in)[i].DeepCopyInto(&(*out)[i])
}
}
(*out)[key] = outVal
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 941a91a263af8c243bfb805ea3115c3001e0d8a2
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with pkg/apis/logging/v1/zz_generated.deepcopy.go at lines 646-658 and read the surrounding deepcopy method, using commit 941a91a263af8c243bfb805ea3115c3001e0d8a2 for context. Determine whether the analyzer's reference-reassignment finding affects this generated code; done means classifying it as Bug, Mitigated, or Desirable Behavior with the requested reaction.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100