github-vet / github-vet/rangeloop-pointer-findings

appgate/sdp-terraform-provider: appgate/resource_appgate_identity_provider_local_database.go; 5 LoC

Open
#17,401 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [appgate/sdp-terraform-provider](https://www.github.com/appgate/sdp-terraform-provider) at [appgate/resource_appgate_identity_provider_local_database.go](https://github.com/appgate/sdp-terraform-provider/blob/d9c23837c9a4ad7060573ad426aaf7e7ef9dcf6a/appgate/resource_appgate_identity_provider_local_database.go#L76-L80)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to s is reassigned at line 78

[Click here to see the code in its original context.](https://github.com/appgate/sdp-terraform-provider/blob/d9c23837c9a4ad7060573ad426aaf7e7ef9dcf6a/appgate/resource_appgate_identity_provider_local_database.go#L76-L80)

Click here to show the 5 line(s) of Go which triggered the analyzer.

```go
for _, s := range provider.GetData() {
if s.GetName() == builtinProviderLocal {
localDatabase = &s
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: d9c23837c9a4ad7060573ad426aaf7e7ef9dcf6a

Contributor guide

No contributing guide indexed for this repository

Research direction

Read appgate/resource_appgate_identity_provider_local_database.go at lines 76-80 and review the Go range-loop reference behavior reported by the analyzer. Compare the finding with the provider's intended local-database selection; done means determining whether the reference can identify the wrong element and leaving the appropriate Bug, Mitigated, or Desirable Behavior reaction.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, terraform
Domain
devops, infrastructure
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.