github-vet / github-vet/rangeloop-pointer-findings

quillaja/hwy: maps/extract.go; 17 LoC

Open
#17,297 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [quillaja/hwy](https://www.github.com/quillaja/hwy) at [maps/extract.go](https://github.com/quillaja/hwy/blob/ba5dd2a89a4d4208ed0f12de39896f3559a3fbb4/maps/extract.go#L150-L166)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

>

[Click here to see the code in its original context.](https://github.com/quillaja/hwy/blob/ba5dd2a89a4d4208ed0f12de39896f3559a3fbb4/maps/extract.go#L150-L166)

Click here to show the 17 line(s) of Go which triggered the analyzer.

```go
for _, s := range doc.States {
s.Parse()
for name, style := range formatters {
// create path for the data /
fmtpath := filepath.Join(path, name)
os.MkdirAll(fmtpath, 0755)

// create file and output data
fname := strings.ToLower(strings.ReplaceAll(s.ID, " ", "_"))
file, err := os.Create(filepath.Join(fmtpath, fname+"."+name))
kill(err)

style(file, &s)

file.Close()
}
}

```

Click here to show extra information the analyzer produced.

```
No path was found through the callgraph that could lead to a function which writes a pointer argument.

No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.

root signature {style 2} was not found in the callgraph; reference was passed directly to third-party code
```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: ba5dd2a89a4d4208ed0f12de39896f3559a3fbb4

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with maps/extract.go lines 150-166 at commit ba5dd2a89a4d4208ed0f12de39896f3559a3fbb4 and review the shown range-loop code in its original context. Determine whether the analyzer finding should be classified as Bug, Mitigated, or Desirable Behavior, then leave the corresponding reaction on the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
devtools
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.