github-vet / github-vet/rangeloop-pointer-findings

orangeglasses/vmug-hackathon: gobot/main.go; 99 LoC

Open
#17,287 0 comments 0 reactions 0 assignees View on GitHub
fresh medium
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [orangeglasses/vmug-hackathon](https://www.github.com/orangeglasses/vmug-hackathon) at [gobot/main.go](https://github.com/orangeglasses/vmug-hackathon/blob/adfcfb3bea0ad27c1dd4aee252babe27364b1d6b/gobot/main.go#L48-L146)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable msg used in defer or goroutine at line 52

[Click here to see the code in its original context.](https://github.com/orangeglasses/vmug-hackathon/blob/adfcfb3bea0ad27c1dd4aee252babe27364b1d6b/gobot/main.go#L48-L146)

Click here to show the 99 line(s) of Go which triggered the analyzer.

```go
for msg := range rtm.IncomingEvents {
go func() {
var wg sync.WaitGroup

switch ev := msg.Data.(type) {

case *slack.MessageEvent:
var username string
userinfo, err := api.GetUserInfo(ev.User)
if err != nil {
username = ev.Username
} else {
username = userinfo.Name
}
fmt.Printf("[%v] said: %v\n", username, ev.Text)

//only listen if tha masta calls me
if username == master && strings.Contains(ev.Text, "gobot") {
replyText := ""

if strings.Contains(ev.Text, "deploy") && strings.Contains(ev.Text, "kubernetes") && kubeScript != "" {
replyText = "Building your kubernetes now"
rtm.SendMessage(rtm.NewOutgoingMessage(replyText, ev.Channel))
postToUi("One kubernetes cluster coming up!")
wg.Add(1)

go func() {
output, err := exec.Command(kubeScript).CombinedOutput()
if err != nil {
rtm.SendMessage(rtm.NewOutgoingMessage(fmt.Sprintf("Ouch, creating the kubernetes cluster failed. Error: %v", err), ev.Channel))
}
fmt.Printf("kubeScript output: %s", output)
rtm.SendMessage(rtm.NewOutgoingMessage(fmt.Sprintf("Kube created: %s ", output), ev.Channel))

postToUi("Kubernetes cluster created!")
postToUi("__roll")

wg.Done()
}()

}

if strings.Contains(ev.Text, "deploy") && strings.Contains(ev.Text, "minecraft") && mineScript != "" {
wg.Wait()
replyText = "One minecraft coming up"
rtm.SendMessage(rtm.NewOutgoingMessage(replyText, ev.Channel))
postToUi(replyText)

go func() {
output, err := exec.Command(mineScript).CombinedOutput()
if err != nil {
rtm.SendMessage(rtm.NewOutgoingMessage(fmt.Sprintf("Ouch, creating the minecraft server failed. Error: %v", err), ev.Channel))
postToUi(fmt.Sprintf("Ouch, creating the minecraft server failed. Error: %v", err))
}
fmt.Printf("mineScript output: %s", output)
rtm.SendMessage(rtm.NewOutgoingMessage(fmt.Sprintf("Minecraft server created: %s ", output), ev.Channel))

postToUi("Minecraft server created!")
postToUi("__roll")

output, err = exec.Command(mineIpScript).CombinedOutput()
if err != nil {
rtm.SendMessage(rtm.NewOutgoingMessage(fmt.Sprintf("Getting IP failed. Error: %v", err), ev.Channel))
}

postToUi(fmt.Sprintf("Minecraft IP: %s", output))
rtm.SendMessage(rtm.NewOutgoingMessage(fmt.Sprintf("Minecraft IP: %s", output), ev.Channel))

}()

}

if replyText == "" {
rtm.SendMessage(rtm.NewOutgoingMessage("I don't understand", ev.Channel))
}
}

if username == "martin" {
rtm.SendMessage(rtm.NewOutgoingMessage("Martin shutup", ev.Channel))
}

case *slack.UserTypingEvent:
userinfo, err := api.GetUserInfo(ev.User)
if err != nil {
return
}
fmt.Printf("User typing: %s\n", userinfo.Name)

case *slack.RTMError:
fmt.Printf("Error: %s\n", ev.Error())

case *slack.InvalidAuthEvent:
fmt.Printf("Invalid credentials")
return

default:
}
}()
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: adfcfb3bea0ad27c1dd4aee252babe27364b1d6b

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.