github-vet / github-vet/rangeloop-pointer-findings
srzkptrsk/purinaBot: user.go; 14 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [srzkptrsk/purinaBot](https://www.github.com/srzkptrsk/purinaBot) at [user.go](https://github.com/srzkptrsk/purinaBot/blob/ed913582064f966366fc63dd1e7137669eed0ae9/user.go#L24-L37)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
>
[Click here to see the code in its original context.](https://github.com/srzkptrsk/purinaBot/blob/ed913582064f966366fc63dd1e7137669eed0ae9/user.go#L24-L37)
Click here to show the 14 line(s) of Go which triggered the analyzer.
```go
for _, user := range users {
if user.Day < 21 {
nowTime, _ := TimeIn(time.Now(), "Europe/Minsk")
userTime, _ := TimeIn(user.CreatedAt, "Europe/Minsk")
if nowTime.Format("2019-01-01") != userTime.Format("2019-01-01") {
user.Day = user.Day + 1
db.Save(&user)
ProcessDay(user.Day, db, bot, int64(user.UserId))
time.Sleep(1 * time.Second)
}
}
}
```
Click here to show extra information the analyzer produced.
```
No path was found through the callgraph that could lead to a function which writes a pointer argument.
No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.
root signature {Save 1} was not found in the callgraph; reference was passed directly to third-party code
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: ed913582064f966366fc63dd1e7137669eed0ae9
Contributor guide
No contributing guide indexed for this repository
Research direction
Review user.go lines 24-37 and the analyzer's extra information first; trace how the range variable is passed to db.Save and ProcessDay. Decide whether this is a real range-loop pointer bug, mitigated, or desirable behavior, then apply the corresponding issue reaction.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100