github-vet / github-vet/rangeloop-pointer-findings
projectatomic/atomic-enterprise: pkg/deploy/controller/deploymentconfig/controller.go; 7 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [projectatomic/atomic-enterprise](https://www.github.com/projectatomic/atomic-enterprise) at [pkg/deploy/controller/deploymentconfig/controller.go](https://github.com/projectatomic/atomic-enterprise/blob/fe3f07ee509de38099565693aecc74e555f971ee/pkg/deploy/controller/deploymentconfig/controller.go#L126-L132)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
>
[Click here to see the code in its original context.](https://github.com/projectatomic/atomic-enterprise/blob/fe3f07ee509de38099565693aecc74e555f971ee/pkg/deploy/controller/deploymentconfig/controller.go#L126-L132)
Click here to show the 7 line(s) of Go which triggered the analyzer.
```go
for _, existing := range existingDeployments.Items {
if deployutil.DeploymentStatusFor(&existing) == deployapi.DeploymentStatusComplete {
desiredReplicas = existing.Spec.Replicas
glog.V(4).Infof("Desired replicas for %s set to %d based on prior completed deployment %s", deployutil.LabelForDeploymentConfig(config), desiredReplicas, existing.Name)
break
}
}
```
Click here to show extra information the analyzer produced.
```
No path was found through the callgraph that could lead to a function which writes a pointer argument.
No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.
root signature {DeploymentStatusFor 1} was not found in the callgraph; reference was passed directly to third-party code
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: fe3f07ee509de38099565693aecc74e555f971ee
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.