projectatomic/atomic-enterprise: pkg/deploy/controller/deployerpod/controller.go; 28 LoC

Found a possible issue in [projectatomic/atomic-enterprise](https://www.github.com/projectatomic/atomic-enterprise) at [pkg/deploy/controller/deployerpod/controller.go](https://github.com/projectatomic/atomic-enterprise/blob/fe3f07ee509de38099565693aecc74e555f971ee/pkg/deploy/controller/deployerpod/controller.go#L138-L165)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

>

[Click here to see the code in its original context.](https://github.com/projectatomic/atomic-enterprise/blob/fe3f07ee509de38099565693aecc74e555f971ee/pkg/deploy/controller/deployerpod/controller.go#L138-L165)

Click here to show the 28 line(s) of Go which triggered the analyzer.

```go
for index, existing := range existingDeployments.Items {
// if a newer deployment exists:
// - set the replicas for the current failed deployment to 0
// - there is no point in scaling up the last completed deployment
// since that will be scaled down by the later deployment
if index == 0 && existing.Name != deployment.Name {
break
}

// the latest completed deployment is the one that needs to be scaled back up
if deployutil.DeploymentStatusFor(&existing) == deployapi.DeploymentStatusComplete {
if existing.Spec.Replicas == desiredReplicas {
break
}

// scale back the completed deployment to the target of the failed deployment
existing.Spec.Replicas = desiredReplicas
if _, err := c.deploymentClient.updateDeployment(existing.Namespace, &existing); err != nil {
if kerrors.IsNotFound(err) {
return nil
}
return fmt.Errorf("couldn't update replicas to %d for deployment %s: %v", desiredReplicas, deployutil.LabelForDeployment(&existing), err)
}
glog.V(4).Infof("Updated replicas to %d for deployment %s", desiredReplicas, deployutil.LabelForDeployment(&existing))

break
}
}

```

Click here to show extra information the analyzer produced.

```
No path was found through the callgraph that could lead to a function which writes a pointer argument.

No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.

root signature {DeploymentStatusFor 1} was not found in the callgraph; reference was passed directly to third-party code
```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: fe3f07ee509de38099565693aecc74e555f971ee