github-vet / github-vet/rangeloop-pointer-findings

zubairhamed/iot-suite-sdk-go: hawkbit/ddi/conn.go; 23 LoC

Open
#17,225 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [zubairhamed/iot-suite-sdk-go](https://www.github.com/zubairhamed/iot-suite-sdk-go) at [hawkbit/ddi/conn.go](https://github.com/zubairhamed/iot-suite-sdk-go/blob/bbc9d9b0b960627421e796e5c434fe0e18eee77a/hawkbit/ddi/conn.go#L157-L179)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable chunk used in defer or goroutine at line 161

[Click here to see the code in its original context.](https://github.com/zubairhamed/iot-suite-sdk-go/blob/bbc9d9b0b960627421e796e5c434fe0e18eee77a/hawkbit/ddi/conn.go#L157-L179)

Click here to show the 23 line(s) of Go which triggered the analyzer.

```go
for _, chunk := range chunks {
var wgArtifacts sync.WaitGroup
wgArtifacts.Add(len(chunk.Artifacts))
go func() {
for _, artifact := range chunk.Artifacts {

// dereference pointer
artifact := *artifact

if parallel {
go func() {
c.doDownloadArtifact(artifact, downloadingCh, downloadedCh)
wgArtifacts.Done()
}()
} else {
c.doDownloadArtifact(artifact, downloadingCh, downloadedCh)
wgArtifacts.Done()
}
}
}()
wgArtifacts.Wait()
wgChunk.Done()
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: bbc9d9b0b960627421e796e5c434fe0e18eee77a

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.