github-vet / github-vet/rangeloop-pointer-findings

haigouhhhh/MIT-6.824-Distributed-System-Labs: src/mapreduce/schedule.go; 9 LoC

Open
#17,169 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [haigouhhhh/MIT-6.824-Distributed-System-Labs](https://www.github.com/haigouhhhh/MIT-6.824-Distributed-System-Labs) at [src/mapreduce/schedule.go](https://github.com/haigouhhhh/MIT-6.824-Distributed-System-Labs/blob/bab6debc75dbb17acbc3126e703e3ba9d7fab45f/src/mapreduce/schedule.go#L62-L70)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable worker used in defer or goroutine at line 66

[Click here to see the code in its original context.](https://github.com/haigouhhhh/MIT-6.824-Distributed-System-Labs/blob/bab6debc75dbb17acbc3126e703e3ba9d7fab45f/src/mapreduce/schedule.go#L62-L70)

Click here to show the 9 line(s) of Go which triggered the analyzer.

```go
for worker := range registerChan {
success := call(worker, "Worker.DoTask", arg, new(struct{}))
if success {
go func() {
registerChan <- worker
}()
break;
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: bab6debc75dbb17acbc3126e703e3ba9d7fab45f

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in src/mapreduce/schedule.go at lines 62-70 and inspect how the range-loop worker is used by the goroutine before tracing the surrounding scheduling flow. Verify the worker returned to registerChan is the intended one and confirm the MapReduce lab tests or execution still schedule tasks correctly after the issue is addressed.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
distributed-systems
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.