github-vet / github-vet/rangeloop-pointer-findings
google/badwolf: bql/planner/data_access.go; 48 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [google/badwolf](https://www.github.com/google/badwolf) at [bql/planner/data_access.go](https://github.com/google/badwolf/blob/7ec96a7527fba8ce1614cb8b82f352211fdc72af/bql/planner/data_access.go#L217-L264)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable g used in defer or goroutine at line 234
[Click here to see the code in its original context.](https://github.com/google/badwolf/blob/7ec96a7527fba8ce1614cb8b82f352211fdc72af/bql/planner/data_access.go#L217-L264)
Click here to show the 48 line(s) of Go which triggered the analyzer.
```go
for _, g := range gs {
gID := g.ID(ctx)
var (
pErr error
aErr error
lErr error
wg sync.WaitGroup
)
tracer.V(2).Trace(w, func() *tracer.Arguments {
return &tracer.Arguments{
Msgs: []string{fmt.Sprintf("g.PredicatesForSubjectAndObject(%v, %v, %s), graph: %s", s, o, loStr, gID)},
}
})
wg.Add(2)
ps := make(chan *predicate.Predicate, chanSize)
go func() {
defer wg.Done()
pErr = g.PredicatesForSubjectAndObject(ctx, s, o, lo, ps)
}()
ts := make(chan *triple.Triple, chanSize)
go func() {
defer wg.Done()
aErr = addTriples(ts, cls, tbl, w)
}()
for p := range ps {
if lErr != nil {
// Drain the channel to avoid leaking goroutines.
continue
}
t, err := triple.New(s, p, o)
if err != nil {
lErr = err
continue
}
ts <- t
}
close(ts)
wg.Wait()
if pErr != nil {
return nil, pErr
}
if aErr != nil {
return nil, aErr
}
if lErr != nil {
return nil, lErr
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 7ec96a7527fba8ce1614cb8b82f352211fdc72af
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.