github-vet / github-vet/rangeloop-pointer-findings

google/badwolf: bql/planner/data_access.go; 27 LoC

Open
#17,131 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [google/badwolf](https://www.github.com/google/badwolf) at [bql/planner/data_access.go](https://github.com/google/badwolf/blob/7ec96a7527fba8ce1614cb8b82f352211fdc72af/bql/planner/data_access.go#L321-L347)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable g used in defer or goroutine at line 337

[Click here to see the code in its original context.](https://github.com/google/badwolf/blob/7ec96a7527fba8ce1614cb8b82f352211fdc72af/bql/planner/data_access.go#L321-L347)

Click here to show the 27 line(s) of Go which triggered the analyzer.

```go
for _, g := range gs {
gID := g.ID(ctx)
var (
tErr error
aErr error
wg sync.WaitGroup
)
tracer.V(2).Trace(w, func() *tracer.Arguments {
return &tracer.Arguments{
Msgs: []string{fmt.Sprintf("g.TriplesForSubject(%v, %s), graph: %s", s, loStr, gID)},
}
})
ts := make(chan *triple.Triple, chanSize)
wg.Add(1)
go func() {
defer wg.Done()
tErr = g.TriplesForSubject(ctx, s, lo, ts)
}()
aErr = addTriples(ts, cls, tbl, w)
wg.Wait()
if tErr != nil {
return nil, tErr
}
if aErr != nil {
return nil, aErr
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 7ec96a7527fba8ce1614cb8b82f352211fdc72af

Contributor guide

No contributing guide indexed for this repository

Research direction

Read bql/planner/data_access.go around lines 321-347 and the linked code context first. Check whether the reported range-loop capture affects the goroutine's behavior, then classify the finding as Bug, Mitigated, or Desirable Behavior using the requested reaction; done means the issue has the appropriate classification.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.