github-vet / github-vet/rangeloop-pointer-findings

vtolstov/cloudmeta: main.go; 20 LoC

Open
#17,088 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [vtolstov/cloudmeta](https://www.github.com/vtolstov/cloudmeta) at [main.go](https://github.com/vtolstov/cloudmeta/blob/1f1a0369cec929c4a7263040209037f1b2458b90/main.go#L154-L173)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable s used in defer or goroutine at line 166

[Click here to see the code in its original context.](https://github.com/vtolstov/cloudmeta/blob/1f1a0369cec929c4a7263040209037f1b2458b90/main.go#L154-L173)

Click here to show the 20 line(s) of Go which triggered the analyzer.

```go
for _, s := range servers.List() {
wait := make(chan struct{})
go func() {
defer func() {
if r := recover(); r != nil {
err, ok := r.(error)
if !ok {
err = fmt.Errorf("pkg: %v", r)
}
fmt.Printf(err.Error())
}
}()
if err := s.Stop(false); err != nil {
panic(err)
}
close(wait)
}()
<-wait
servers.Del(s.name)
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 1f1a0369cec929c4a7263040209037f1b2458b90

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with main.go lines 154-173 and review the goroutine and defer usage around the range over servers.List(). Confirm whether the analyzer warning represents a real defect, then verify the chosen classification against the shown behavior and any available checks; done means the finding is accurately classified.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.