github-vet / github-vet/rangeloop-pointer-findings

projectcalico/felix: policysync/processor.go; 5 LoC

Open
#17,085 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [projectcalico/felix](https://www.github.com/projectcalico/felix) at [policysync/processor.go](https://github.com/projectcalico/felix/blob/c8a6c0b2a407a3bf2b995de3ccb91d2f8b115f22/policysync/processor.go#L481-L485)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to polID was used in a composite literal at line 483

[Click here to see the code in its original context.](https://github.com/projectcalico/felix/blob/c8a6c0b2a407a3bf2b995de3ccb91d2f8b115f22/policysync/processor.go#L481-L485)

Click here to show the 5 line(s) of Go which triggered the analyzer.

```go
for polID := range oldSyncedPolicies {
ei.output <- proto.ToDataplane{Payload: &proto.ToDataplane_ActivePolicyRemove{
ActivePolicyRemove: &proto.ActivePolicyRemove{Id: &polID},
}}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: c8a6c0b2a407a3bf2b995de3ccb91d2f8b115f22

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.