github-vet / github-vet/rangeloop-pointer-findings
winstarshl/pip-services3-commons-go-vgo: reflect/RecursiveObjectReader.go; 18 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [winstarshl/pip-services3-commons-go-vgo](https://www.github.com/winstarshl/pip-services3-commons-go-vgo) at [reflect/RecursiveObjectReader.go](https://github.com/winstarshl/pip-services3-commons-go-vgo/blob/32a7c2c593848fd3b86dca7211fd272eb10bdd9c/reflect/RecursiveObjectReader.go#L136-L153)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
>
[Click here to see the code in its original context.](https://github.com/winstarshl/pip-services3-commons-go-vgo/blob/32a7c2c593848fd3b86dca7211fd272eb10bdd9c/reflect/RecursiveObjectReader.go#L136-L153)
Click here to show the 18 line(s) of Go which triggered the analyzer.
```go
for key, value := range values {
// Prevent cycles
if c.contains(cycleDetect, &value) {
continue
}
if path != "" {
key = path + "." + key
}
// Add simple values directly
if c.isSimpleValue(value) {
result[key] = value
} else {
// Recursively go to elements
result = c.performGetProperties(value, key, result, cycleDetect)
}
}
```
Click here to show extra information the analyzer produced.
```
No path was found through the callgraph that could lead to a function which writes a pointer argument.
No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.
root signature {contains 2} was not found in the callgraph; reference was passed directly to third-party code
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 32a7c2c593848fd3b86dca7211fd272eb10bdd9c
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by reading reflect/RecursiveObjectReader.go around lines 136-153 at commit 32a7c2c593848fd3b86dca7211fd272eb10bdd9c, including the surrounding cycle-detection logic. Determine whether the range-loop reference is a bug, mitigated, or desirable behavior; done means recording one of those classifications on the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100